WIP add support for Subresource Integrity #1029
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far this PR just adds the
webpack-subresource-integrityplugin todotcom-build-base, and configures things to output the integrity hashes in the manifest.we'd still need to have
dotcom-ui-bootstrapoutput these hashes in theintegrityattribute. however, the asset loader, shell and bootstrap all just expect an array of strings, and changing that all the way through was proving to be annoying.tbh the asset loader seems unnecessarily complex, and has a lot of functionality that i'm pretty sure people aren't using. i'm tempted to rewrite it.