DO NOT MERGE prevent importing Sass/CSS from JS #1160
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is currently "possible", as that's just what
css-loaderdoes, but it's seemingly not compatible with the asset loader (not entirely sure why;mini-css-extract-pluginshould be able to extract these and output them in the asset manifest just fine. i will do some more testing).since this is broken, and not an intended use case, i think it's best to prevent engineers doing this, so they can get earlier feedback about something that's not going to work.
after some discussion at Dev Huddle, we came to the consensus that this is fine to release as a patch version; nobody is aware of any use of CSS imports from JS, and there was agreement that going from silently broken styles in prod to a build failure is a non-breaking change for an undocumented feature.