Soundscape metrics hybrid millidecade #108
Conversation
Fixes errors when computing soundscape metrics related to reading in soundscape metrics LTSAs.
There was a problem hiding this comment.
Hi Clara,
I noticed that this change modifies Remoras/Logger/pathdef.m. pathdef.m is usually a MATLAB internal command that sets the path. It is located in the matlab distribution, e.g., Program Files\MATLAB\ReleaseVer[e.g.,, R2022b]\ toolbox \local\pathdef.m
We should not be creating a file like this in a Remora directory and I do not see it called from the Logger remora. The problem with committing a hard coded path, e.g. the entries C:\Users\HARP\Documents\GitHub... is that it breaks for any other user. If it is not used, it should be rmeoved (didn't see any usages, but I didn't look real hard either).
All my best - Marie
|
Hi Marie, Thanks for catching that! You are correct, I don't want to push that file to the master branch and it isn't called anywhere in the changes I've made. I have removed it so hopefully the pull request is updated? If not I can delete this one and create another. Thanks! Clara |
Soundscape metrics Remora now includes the analysis type hybrid millidecade.