-
Notifications
You must be signed in to change notification settings - Fork 31
Updates to Batch LTSA Remora for multichannel data #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfregosi-noaa
wants to merge
24
commits into
MarineBioAcousticsRC:master
Choose a base branch
from
sfregosi:batchLTSA-multichannel-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates to Batch LTSA Remora for multichannel data #115
sfregosi-noaa
wants to merge
24
commits into
MarineBioAcousticsRC:master
from
sfregosi:batchLTSA-multichannel-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you want to skip some dirs of xwavs/wavs nested within a larger dir, just change taves and dfreqs to blank in the parameter check GUI
tethys early 2023 changes
catch up to MBARC master
catch up with MBARC
newest release
catch up to MBARC
rather than using PARAMs and overwriting
with warnings if they don't align working for single channel data
@jtrickey86 tested this on a second computer and didn't have any issues so moving this from draft to requesting review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes overhaul how the Batch LTSA handles multichannel data and provide detailed documentation for each function and a draft Wiki page for the remora.
Functionality updates
Previously, the Batch LTSA Remora would create separate LTSAs for all channels. Now, there is an option to either create individual LTSAs for all channels or just specify a single channel to process. This was requested because when working with towed array data it was overkill (and took a long time) to process all 7 channels.
The initial setup GUI now prompts the user to specify if the input files are multichannel or single channel and to enter the channel number to process. For single channel data this should be 1; for multichannel data this can be any number of the available channels or can be set to 0 to calculate LTSAs for all channels. Like the other settings (
tave
anddfreq
) the channel to process can be set individually for each directory at the second settings window. For example, one directory could process channel 3, another could process channel 1, another could process all channels.Documentation updates
All functions now include detailed documentation that will properly populate/format using
help
anddoc
within MATLAB.I drafted a Wiki page for this remora. It is in the BatchLTSA folder in the 'wiki' folder and I've also copied it here. It refers to some screenshots which are in the wiki folder and attached here. The links to include those screenshots won't work (since they won't map until they've actually been uploaded to GitHub) but all the pieces should be available or I'm happy to provide more help there if needed.
Notes
decimatewav
,calc_ltsa
, andtriton
just fix types or small bugs