Added ability to automatically create parameters for unconnected ODE inputs. #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fix for vars deeper in the hierarchy
naylor-b
approved these changes
Sep 8, 2025
dymos/phase/phase.py
Outdated
| self.options.declare('boundary_balance_options', types=dict, default={}, | ||
| desc='Options specifying boundary conditions to be satisfied with a solver.') | ||
| self.options.declare('auto_add_parameters', types=bool, default=False, | ||
| desc='If True, add any otherwise-unconnected ODE inputs add non-optimal parameters.') |
There was a problem hiding this comment.
typo? 'add non-optimal parameters' --> 'as non-optimal parameters'
| # Add the remaining unconnected inputs as parameters | ||
| for inp in unconn_inputs: | ||
| if '.' in inp: | ||
| # Handle parameters nested in the ODE |
There was a problem hiding this comment.
If you have an input rhs_all.a.b.c that isn't promoted, isn't this code just going to add a parameter for "c"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added new option to Phase:
auto_add_parametersThis currently defaults to
Falseas it is still experimental.If it is True, then Dymos will determine those inputs in the ODE that are not otherwise connected via promotion or manual connections, and create corresponding parameters for them.
If an unconnected input is not promoted to the top of the ODE, the corresponding parameter name will just be the name of the variable itself. For example, a variable at a path
'aircraft.wing.mass'within the ODE hierarchy will just have the parameter name'mass'.If two variables within the ODE share the same local name, dymos will work backwards through the dotted path and replace dots with underscores, until a unique name is found.
For instance, if the ODE contained paths:
'aircraft.wing.mass'and'aircraft.landing_gear.mass', the added parameters would have names'wing_mass'and'landing_gear_mass', respectively.Related Issues
Backwards incompatibilities
None
New Dependencies
None