Add macOS CI #1240
Open
Add macOS CI #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b057241.
|
Seems macOS still segfaults on 6.7, I was hoping this was just a classic pyside broken build that would magically fix itself in the next update. I suspect the issue has to do with QT not running on the main thread, macOS is picky about which threads GUI applications are using. The good news is there is a pytest plugin that fixes this! Bad news, it is a pytest plugin, and to use it means marrying our tests to pytest which we have done up to this point, and isn't compatible with the angr ci. So if we use it, it needs to be done in an optional way, at least for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.