added changes to deal with datatype #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamkank
reviewed
Jan 10, 2019
| break | ||
| return data_rows | ||
|
|
||
| def data_type_check(self, cell_data,column_names): |
There was a problem hiding this comment.
Unfortunately this doesn't seem to be working for examples/example_a.csv because the adopted_since column contains an integer value in the first row, but later has a string value (N/A) in that same column. One fix I can think of is rebuilding the cell_type list in the main file for every row we visit.
|
|
||
| while row < len(cell_data): | ||
| while col < (len(column_names)): | ||
| if accountid.match(cell_data[row][col]): |
There was a problem hiding this comment.
Similarly here, can we get rid of this accountid case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.