Add new track type for GWAS summary statistics/variants #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd use it for the gwas track.
…nd use it for the gwas track.
# Conflicts: # pygenometracks/tests/test_gwasTrack.py # pygenometracks/tracks/GenomeTrack.py # pygenometracks/tracks/GwasTrack.py # pygenometracks/tracksClass.py
|
Hi, |
|
Hi @AnttonLA , |
lldelisle
reviewed
Sep 27, 2025
| return val | ||
|
|
||
| if self.properties['y_values_format'] == 'PP': | ||
| y = df['P'].apply(floor) |
There was a problem hiding this comment.
I don't know GWAS but I am under the impression that with this line all y values will be to 0, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back I created a "GWAS track" for personal use to display individual genetic variants in a scatterplot as a separate track.
It is quite rough, as it was done ad hoc.
It takes data in the IGV .gwas format (see: https://igv.org/doc/desktop/#FileFormats/DataTracks/#gwas)
I just wanted to gauge interest in making this a proper addition to the tool.
Is this in scope? What would be needed for a proper pull request?
Example image:
