-
Notifications
You must be signed in to change notification settings - Fork 18
Add OptSolvX adapter, demo, tests, and docs (initial SBSCL integration) #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xts-Michi
wants to merge
11
commits into
draeger-lab:master
Choose a base branch
from
xts-Michi:feature/optsolvx-integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add OptSolvX adapter, demo, tests, and docs (initial SBSCL integration) #88
xts-Michi
wants to merge
11
commits into
draeger-lab:master
from
xts-Michi:feature/optsolvx-integration
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ctor) and changed the pom OptSolvX verison to java 8
…nds, S·v=0, objective) into OptSolvX
…ective tests using jdk 8 artifact
…e FbaToOptSolvX preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
draeger
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please coordinate with Ayush that all tests from the SBML test suite run smoothly, including fbc tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge yet — updated scope below 👇
Summary
Wires SBSCL ↔ OptSolvX via a small solver adapter and adds a first SBML/FBC → LP bridge skeleton. Includes a runnable demo, unit tests, and short docs. No existing code paths are changed; OptSolvX stays Java-8 compatible (jdk8 classifier).
Changes
Adapter
org.simulator.optsolvx.OptSolvXSolverAdapter
null
+build()
), delegates to CommonsMathSolver.SBML/FBC → LP bridge (new)
org.simulator.optsolvx.FbaToOptSolvX
(skeleton)vars/cons/objective/dir
) to aid debugging.Tests
org.simulator.optsolvx.OptSolvXSolverAdapterTest
solve_requires_non_null_model
(IAE)solve_requires_build
(ISE)smoke_minimize_with_eq_and_bounds
(min 2x+y, x+y=5 → x=0,y=5,obj=5)Bridge tests (new):
org.simulator.optsolvx.BridgeSmokeTest
org.simulator.optsolvx.BridgeObjectiveTest
Docs
How to run
Demo (IDE):
org.simulator.optsolvx.OptSolvXDemo
Tests (Maven):
mvn -q -Dtest=org.simulator.optsolvx.OptSolvXSolverAdapterTest test
mvn -q -Dtest=org.simulator.optsolvx.BridgeSmokeTest,org.simulator.optsolvx.BridgeObjectiveTest test
mvn -q -Dtest=org.simulator.optsolvx.* test
Open items / Next
FbaToOptSolvX
mapping (full stoichiometry constraints, reversible flux handling, edge cases).