Add context.Context support to API methods #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds context.Context to HTTP requests for cancellation/timeouts, as requested in #108.
context.Background()
....WithContext
is preferred, adjustname_suffix="Context"
and'Context('
in the generator.ctx
in arg structs).dropbox.context.Execute
is changed to takectx
, based on the assumption that this method is internal.Execute
, the call tohttp.NewRequest
is replaced withhttp.NewRequestWithContext
.// UploadContext is the context-aware version of Upload.
could be added.Generated code is not updated by this commit. Example of impact:
Before:
After:
Closes #108.