Skip to content

Xarray non dimensional kdims #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Xarray non dimensional kdims #6132

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4571b91
make irregaluar if non-dimensional coordinate
hoxbro Feb 26, 2024
ec21d7a
Add check for dims in data
hoxbro Feb 27, 2024
5f59140
Only check in values
hoxbro Feb 27, 2024
4e7b3f7
Move irregular to xarray interface
hoxbro Feb 27, 2024
a09b491
Merge branch 'main' into xarray_non_dimensional
hoxbro Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions holoviews/core/data/xarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,13 @@ def validate(cls, dataset, vdims=True):
"non-matching array dimensions:\n\n%s"
% ('\n'.join(nonmatching)), cls)

@classmethod
def irregular(cls, dataset, dim):
if dataset.data[dimension_name(dim)].ndim > 1:
return True
dim_name = dimension_name(dim)
return dim_name not in dataset.data.dims and dim_name in dataset.data.coords

@classmethod
def compute(cls, dataset):
return dataset.clone(dataset.data.compute())
Expand Down