Skip to content

compat: cuDF 25.08 #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

compat: cuDF 25.08 #6659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion holoviews/core/data/cudf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def select(cls, dataset, selection_mask=None, **selection):

indexed = cls.indexed(dataset, selection)
if selection_mask is not None:
df = df.iloc[selection_mask]
df = df.loc[selection_mask]
Copy link
Member Author

@hoxbro hoxbro Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else test would error:

.pixi/envs/test-gpu/lib/python3.12/site-packages/cudf/core/indexing_utils.py:118: KeyError
=================================================================================================================== short test summary info ===================================================================================================================
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_second_dim - KeyError: '0     True\n1    False\n2    False\nName: Age, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_column_idx_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6     False\n7     False\n8     False\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_item_table - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_age - KeyError: '0    False\n1    False\n2     True\nName: Age, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_gender_female - KeyError: '0    False\n1    False\n2     True\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_rows_gender_male - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_value1 - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_index_value2 - KeyError: '0    False\n1    False\n2     True\ndtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_alias - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_alias_dict - KeyError: '0     True\n1     True\n2    False\nName: gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_dict - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_dimension_dict - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_expr - KeyError: '0     True\n1     True\n2    False\nName: Gender, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_fn_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_hm - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_slice_hm_alias - KeyError: '0     False\n1     False\n2     False\n3     False\n4     False\n5      True\n6      True\n7      True\n8      True\n9     False\n10    False\nName: x, dtype: bool: boolean label can not be used without a boolean index'
FAILED holoviews/tests/core/data/test_cudfinterface.py::cuDFInterfaceTests::test_dataset_value_dim_scalar_index - KeyError: '0     True\n1    False\n2    False\ndtype: bool: boolean label can not be used without a boolean index'
=========================================================================================== 22 failed, 105 passed, 1 skipped, 5471 deselected, 2 xfailed in 13.28s ============================================================================================

if indexed and len(df) == 1 and len(dataset.vdims) == 1:
return df[dataset.vdims[0].name].iloc[0]
return df
Expand Down
4 changes: 2 additions & 2 deletions pixi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ NUMBA_CUDA_LOW_OCCUPANCY_WARNINGS = "0"

[feature.test-gpu.dependencies]
cuda-version = "12.2.*"
cudf = "25.06.*"
cudf = "25.08.*"
cupy = "*"
# cuspatial = "*" # https://github.com/rapidsai/cuspatial/issues/1563#issuecomment-2845966364
# cuspatial = "*" # Paused development: https://docs.rapids.ai/notices/rsn0045/
librmm = { version = "*", channel = "rapidsai" }
rmm = { version = "*", channel = "rapidsai" }

Expand Down
Loading