-
Notifications
You must be signed in to change notification settings - Fork 3
attempt fix for #8 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@joeblew999 and @lynaghk, could you test this branch and see if Mac issue is fixed? |
On my M1 Macbook Air 14.7.5 (23H527)
|
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Hmm I missed something it seems. Maybe try now? |
Same output, unfortunately.
|
…nctions and better timing logs
Alright, fixed. You had run into a latent bug created during a refactor that happened a while ago (for CPU runs). Now it should (hopefully) work :) |
Yeah seems to have worked on CPU (though no window pops up or anything, not sure if something is supposed to be visible). GPU mode still has issues, though:
|
Odd, i inserted panics all over to catch where it fails. You ran with latest? |
Yeah, this was on 7948221 |
No description provided.