Skip to content
This repository was archived by the owner on Jul 9, 2021. It is now read-only.

@0x/order-utils refactors for v3: orderParsingUtils, signatureUtils, orderHashUtils, RevertErrors, transactionHashUtils #2321

Merged
merged 18 commits into from
Nov 14, 2019
Merged

@0x/order-utils refactors for v3: orderParsingUtils, signatureUtils, orderHashUtils, RevertErrors, transactionHashUtils #2321

merged 18 commits into from
Nov 14, 2019

Conversation

feuGeneA
Copy link
Contributor

@feuGeneA feuGeneA commented Nov 7, 2019 •
edited
Loading

  • Move orderParsingUtils into @0x/connect.
  • From signatureUtils, remove:
    • isValidSignatureAsync
    • isValidPresignedSignatureAsync
    • isValidWalletSignatureAsync
    • isValidValidatorSignatureAsync
    • isValidECSignature
    • isValidWalletSignatureAsync
  • Remove orderHashUtils.isValidOrderHash().
  • Change all non-contract-test callers of orderHashUtils.getOrderHash() to call into the Exchange.getOrderInfo() contract method instead, and move orderHashUtils.getOrderHash() into @0x/contracts-test-utils.
  • Move *RevertError types out of @0x/order-utils and into their respective @0x/contracts-* packages.
  • Move *RevertError types out of @0x/utils and into their respective @0x/contracts-* packages.
  • Delete transactionHashUtils.isValidTransactionHash().
  • Refactor transactionHashUtils.getTransactionHashHex() to use contract wrapper call. [Note: I took a slightly different approach than what was prescribed. The situation was very similar to the one for getOrderHash(). That is, the vast majority of callers were in tests of contracts, so I moved the existing implementation into @0x/contracts-test-utils, exposed a new getTransactionHash() method on the DevUtils contract, and changed all non-contract-test callers to call into directly the contract method instead.)

@feuGeneA feuGeneA self-assigned this Nov 7, 2019
@buildsize
Copy link

buildsize bot commented Nov 7, 2019 •
edited
Loading

File name Previous Size New Size Change
init.py 26.91 KB 26.91 KB 0 bytes (0%)
abi_gen_dummy.ts 112.85 KB [deleted]
lib_dummy.ts 7.04 KB [deleted]
test_lib_dummy.ts 12.09 KB [deleted]
environment.pickle 1.61 MB 1.61 MB 0 bytes (0%)
index.doctree 184.8 KB 184.8 KB 0 bytes (0%)
.buildinfo 230 bytes 230 bytes 0 bytes (0%)
genindex.html 5.6 KB 5.6 KB 0 bytes (0%)
index.html 2.52 KB 2.52 KB 0 bytes (0%)
objects.inv 375 bytes 375 bytes 0 bytes (0%)
py-modindex.html 3.07 KB 3.07 KB 0 bytes (0%)
search.html 2.84 KB 2.84 KB 0 bytes (0%)
searchindex.js 6.28 KB 6.28 KB 0 bytes (0%)
index.rst.txt 415 bytes 415 bytes 0 bytes (0%)
alabaster.css 10.92 KB 10.92 KB 0 bytes (0%)
basic.css 11.89 KB 11.89 KB 0 bytes (0%)
custom.css 42 bytes 42 bytes 0 bytes (0%)
doctools.js 9.05 KB 9.05 KB 0 bytes (0%)
documentation_options.js 303 bytes 303 bytes 0 bytes (0%)
file.png 286 bytes 286 bytes 0 bytes (0%)
jquery-[version].js 273.79 KB 273.79 KB 0 bytes (0%)
jquery.js 86.08 KB 86.08 KB 0 bytes (0%)
language_data.js 10.59 KB 10.59 KB 0 bytes (0%)
minus.png 90 bytes 90 bytes 0 bytes (0%)
plus.png 90 bytes 90 bytes 0 bytes (0%)
pygments.css 4.69 KB 4.69 KB 0 bytes (0%)
searchtools.js 15.61 KB 15.61 KB 0 bytes (0%)
underscore-[version].js 34.34 KB 34.34 KB 0 bytes (0%)
underscore.js 11.86 KB 11.86 KB 0 bytes (0%)
contract_addresses.html 16.8 KB 16.8 KB 0 bytes (0%)
contract_artifacts.html 8.24 KB 8.24 KB 0 bytes (0%)
json_schemas.html 12.55 KB 12.55 KB 0 bytes (0%)
order_utils.html 46.85 KB 46.85 KB 0 bytes (0%)
erc20_token.html 93.31 KB 93.31 KB 0 bytes (0%)
exchange.html 678.51 KB 678.51 KB 0 bytes (0%)
tx_params.html 9.41 KB 9.41 KB 0 bytes (0%)
local_message_signer.html 15.07 KB 15.07 KB 0 bytes (0%)
asset_data_utils.html 22.65 KB 22.65 KB 0 bytes (0%)
default_api.html 113.16 KB 113.16 KB 0 bytes (0%)
asset_proxy_owner.html 350.44 KB 350.44 KB 0 bytes (0%)
coordinator.html 133.77 KB 133.77 KB 0 bytes (0%)
coordinator_registry.html 39.72 KB 39.72 KB 0 bytes (0%)
dutch_auction.html 59.6 KB 59.6 KB 0 bytes (0%)
erc20_proxy.html 111 KB 111 KB 0 bytes (0%)
erc721_proxy.html 111.12 KB 111.12 KB 0 bytes (0%)
erc721_token.html 148.29 KB 148.29 KB 0 bytes (0%)
forwarder.html 110.46 KB 110.46 KB 0 bytes (0%)
i_asset_proxy.html 39.32 KB 39.32 KB 0 bytes (0%)
i_validator.html 30.37 KB 30.37 KB 0 bytes (0%)
i_wallet.html 27.63 KB 27.63 KB 0 bytes (0%)
multi_asset_proxy.html 148.59 KB 148.59 KB 0 bytes (0%)
order_validator.html 120.52 KB 120.52 KB 0 bytes (0%)
weth9.html 133.98 KB 133.98 KB 0 bytes (0%)
zrx_token.html 111.93 KB 111.93 KB 0 bytes (0%)
dev_utils.html 580.48 KB 580.48 KB 0 bytes (0%)
types.html 8.68 KB 8.68 KB 0 bytes (0%)
erc1155_mintable.html 288.23 KB 288.23 KB 0 bytes (0%)
erc1155_proxy.html 129.7 KB 129.7 KB 0 bytes (0%)
static_call_proxy.html 39.44 KB 39.44 KB 0 bytes (0%)

@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch from ef61968 to d60a59b Compare November 7, 2019 04:19
@feuGeneA feuGeneA changed the title @0x/order-utils refactors for v3: orderParsingUtils, signatureUtils, orderHashUtils @0x/order-utils refactors for v3: orderParsingUtils, signatureUtils, orderHashUtils, RevertErrors Nov 7, 2019
@coveralls
Copy link

coveralls commented Nov 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 75.743% when pulling 7937304 on feuGeneA/order-utils-v3-refactors into f0d7d10 on development.

@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch 2 times, most recently from bbbd89a to 62bfdc1 Compare November 9, 2019 00:39
@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch 7 times, most recently from 36c2ee1 to 99e42f3 Compare November 9, 2019 17:53
@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch 2 times, most recently from 2419b96 to d62efa7 Compare November 13, 2019 14:56
@feuGeneA
Refactor @0x/order-utils transactionHashUtils away
f89144d 
- Move existing routines into @0x/contracts-test-utils

- Migrate non-contract-test callers to a newly-exposed
getTransactionHash() method in DevUtils.
@feuGeneA
Consolidate Removed export... CHANGELOG entries
12ec38d
@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch from d62efa7 to cf5314c Compare November 13, 2019 15:22
@feuGeneA feuGeneA force-pushed the feuGeneA/order-utils-v3-refactors branch from 7060ea9 to 2f926a9 Compare November 13, 2019 18:25
@feuGeneA feuGeneA marked this pull request as ready for review November 13, 2019 19:05
fabioberger
fabioberger suggested changes Nov 13, 2019
View reviewed changes
@xianny xianny force-pushed the feuGeneA/order-utils-v3-refactors branch from bd9c3aa to 6017c4e Compare November 14, 2019 17:06
@feuGeneA feuGeneA merged commit f11d8a5 into development Nov 14, 2019
@fabioberger fabioberger deleted the feuGeneA/order-utils-v3-refactors branch November 14, 2019 22:16
feuGeneA added a commit that referenced this pull request Nov 20, 2019
@feuGeneA
Add updated DevUtils contract artifact
fd12116 
New contract methods were added in #2321, but this artifact was not
updated.
@feuGeneA feuGeneA mentioned this pull request Nov 21, 2019
Merged
feuGeneA added a commit that referenced this pull request Nov 21, 2019
@feuGeneA
Updated DevUtils contract artifact (#2358)
daa593d 
* Add updated DevUtils contract artifact

New contract methods were added in #2321, but this artifact was not
updated.

* fix for breaking change in eth_utils
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abandeali1 abandeali1 Awaiting requested review from abandeali1 abandeali1 is a code owner

@fragosti fragosti Awaiting requested review from fragosti

@hysz hysz Awaiting requested review from hysz

1 more reviewer

@fabioberger fabioberger fabioberger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@feuGeneA feuGeneA

Labels
0x.js @0x/connect @0x/contract-wrappers @0x/contracts-asset-proxy @0x/contracts-coordinator @0x/contracts-dev-utils @0x/contracts-erc1155 @0x/contracts-exchange @0x/contracts-exchange-forwarder @0x/contracts-exchange-libs @0x/contracts-extensions @0x/contracts-integrations @0x/contracts-multisig @0x/contracts-staking @0x/contracts-test-utils @0x/contracts-tests @0x/contracts-utils @0x/order-utils @0x/orderbook @0x/utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feuGeneA @coveralls @fabioberger @xianny