This repository was archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 460
Remove unused contract wrappers #2324
Merged
fabioberger
merged 24 commits into
development
from
refactor/removeUnusedContractWrappers
Nov 11, 2019
Merged
Remove unused contract wrappers #2324
fabioberger
merged 24 commits into
development
from
refactor/removeUnusedContractWrappers
Nov 11, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xianny
reviewed
Nov 8, 2019
xianny
reviewed
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about instantiating ExchangeTransferSimulator
with an instance of DevUtilsContract
instead of a provider.
Everything else looks good to me! Thanks for updating exchange_transfer_simulator_test.ts
with the blockchainTests
pattern.
xianny
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved after CI passes!
dekz
reviewed
Nov 11, 2019
…wrappers and contract-wrappers packages
…t's the only place it's still used and we no longer want to expose it to external developers
…sses now that we don't deploy DutchAuction anymore
258a2a4
to
90640a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
ZRXToken
,DutchAuction
and all assetProxy contracts fromabi-gen-wrappers
andcontract-wrapper
packages in an effort to make these packages smaller.ExchangeTransferSimulator
tests out oforder-utils
in order to have the tests continue to refer tocontract-*
wrappers no longer available viaabi-gen-wrappers
without importing a bunch of wrappers intoorder-utils
. We wanted to move this and it's deps anyways intocontracts-exchange
since that is the only place that still uses this functionality and we want to re-direct external devs to useDevUtils
wrapper methods for order validation.Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.