Skip to content

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jul 18, 2023

LD_LIBRARY_PATH is evil, removing. Replace with the

  • $ORIGIN token for linux
  • or @rpath for darwin

Other fixes:

  • tests improves to openmldb-jdbc
  • testing CREATE FUNCTION in openmldb-jdbc
  • improve onebox scripts with pidfile
  • maven-commit-id-plugin: default to offline mode

LD_LIBRARY_PATH is evil, removing. Replace with the
- $ORIGIN token for linux
- or @rpath for darwin
@github-actions github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2fbc906) 37.32% compared to head (229d765) 37.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3373   +/-   ##
=========================================
  Coverage     37.32%   37.32%           
  Complexity      414      414           
=========================================
  Files           178      178           
  Lines         10308    10308           
  Branches       1206     1206           
=========================================
  Hits           3847     3847           
  Misses         6220     6220           
  Partials        241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Jul 19, 2023

Doc about udf dir should fix https://openmldb.ai/docs/zh/main/openmldb_sql/udf_develop_guide.html?highlight=udf#id9

And I strongly recommend this pr don't be released before it has enough tests(integration). We should add tests asap

@aceforeverd
Copy link
Collaborator Author

Doc about udf dir should fix https://openmldb.ai/docs/zh/main/openmldb_sql/udf_develop_guide.html?highlight=udf#id9

And I strongly recommend this pr don't be released before it has enough tests(integration). We should add tests asap

No worry, I'll add tests in this PR. Original LD_LIBRARY_PATH is never consider stable, since it was never tested, from CICD

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Jul 20, 2023

Doc about udf dir should fix https://openmldb.ai/docs/zh/main/openmldb_sql/udf_develop_guide.html?highlight=udf#id9
And I strongly recommend this pr don't be released before it has enough tests(integration). We should add tests asap

No worry, I'll add tests in this PR. Original LD_LIBRARY_PATH is never consider stable, since it was never tested, from CICD

Very Good! Original LD_LIBRARY_PATH at least works on user's production env and no bug report now, so it could be a stable one. I don't want too many changes all in one version.

FTR We'll consider 0.8.2 as a stable version about udf and hive, if new version get error, test on 0.8.2

@github-actions github-actions bot added workflow CICD related sdk openmldb java/python sdk labels Jul 20, 2023
@github-actions github-actions bot added the task-manager openmldb taskmanager label Jul 25, 2023
@aceforeverd
Copy link
Collaborator Author

openmldb-batch test fails on mac:

ERROR: something wrong with flag 'logtostderr' in file 'src/logging.cc'. One possibility: file 'src/logging.cc' is being linked both statically and dynamically into this executable.

- assert expected exceptions with testng
- upgrade testng to 7.5.1
- improve start_onebox.sh
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Jul 28, 2023
@aceforeverd
Copy link
Collaborator Author

aceforeverd commented Aug 15, 2023

TODO:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine build openmldb compiling and installing execute-engine hybridse sql engine sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants