Timer improvement #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
C-Achard
commented
Aug 11, 2022
C-Achard
commented
- Improved timer for review as discussed with @vidalmaxime : instead of a per-slice timer, it is now global and can be paused when needed. That time amount is recorded in the review csv and recovered on subsequent review sessions
- Improved timer for review as discussed with Max : instead of a per-slice timer, it is now global and can be paused when needed. That time amount is recorded in the csv and recovered on subsequent review sessions
|
Preview page for your plugin is ready here: |
vidalmaxime
reviewed
Aug 12, 2022
vidalmaxime
suggested changes
Aug 12, 2022
There was a problem hiding this comment.
Overall looks great :) One minor comment is that one of the good things about version control is that you can always go back to previous commits to check modified code. Because of this, I would suggest to remove the commented parts here for better readability.
Removed old code
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 37.34% 37.84% +0.50%
==========================================
Files 37 37
Lines 3449 3464 +15
==========================================
+ Hits 1288 1311 +23
+ Misses 2161 2153 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vidalmaxime
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.