Skip to content

Conversation

MMathisLab
Copy link
Member

@MMathisLab MMathisLab commented Apr 21, 2023

  • make itk and pyqt5 "optional dependency, as for m1 they cause issues!

conda env create -f cellseg3d_m1.yml
conda activate cellseg3d_m1

  • then run:
  • conda install -c anaconda pyqt in the env

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Merging #38 (0707e42) into main (ec94453) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   55.21%   55.18%   -0.03%     
==========================================
  Files          44       44              
  Lines        4209     4211       +2     
==========================================
  Hits         2324     2324              
- Misses       1885     1887       +2     
Impacted Files Coverage Δ
napari_cellseg3d/code_models/model_workers.py 24.59% <ø> (ø)
napari_cellseg3d/code_plugins/plugin_crop.py 34.61% <0.00%> (ø)
napari_cellseg3d/dev_scripts/convert.py 0.00% <0.00%> (ø)
napari_cellseg3d/dev_scripts/view_brain.py 0.00% <0.00%> (ø)
napari_cellseg3d/dev_scripts/view_sample.py 0.00% <0.00%> (ø)
napari_cellseg3d/utils.py 58.25% <16.66%> (-1.07%) ⬇️
napari_cellseg3d/code_plugins/plugin_base.py 67.33% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MMathisLab MMathisLab requested a review from C-Achard April 21, 2023 14:45
@C-Achard
Copy link
Collaborator

I'll use this one to get rid of duplicate fields in setup.cfg as well !

@C-Achard C-Achard requested a review from jeylau April 22, 2023 10:06
@C-Achard
Copy link
Collaborator

@MMathisLab setup.cfg has been greatly reduced, itk and dask removed (after checking where it is used, seems it was only for monai imwrite which is not used); and a "Save location" tooltip has been added.

If you have the time, could you quickly confirm that the install procedure for M1 in the README works as intended ? Thanks !

Copy link
Member Author

@MMathisLab MMathisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@C-Achard C-Achard added documentation Improvements or additions to documentation fix Something needs to be or has been fixed labels Apr 23, 2023
MMathisLab and others added 11 commits April 23, 2023 15:31
- make itk and pyqt5 "optional dependency, as for m1 they cause issues!
- then run: `conda install -c anaconda pyqt` in the env
- Remove dask and itk requirements
- Comment duplicate sections in setup.cfg
@C-Achard C-Achard merged commit ce4307d into main Apr 26, 2023
@C-Achard C-Achard deleted the MMathisLab-toml branch April 26, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix Something needs to be or has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants