-
Notifications
You must be signed in to change notification settings - Fork 17
Update pyproject.toml; minimal conda for m1 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 55.21% 55.18% -0.03%
==========================================
Files 44 44
Lines 4209 4211 +2
==========================================
Hits 2324 2324
- Misses 1885 1887 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'll use this one to get rid of duplicate fields in setup.cfg as well ! |
@MMathisLab setup.cfg has been greatly reduced, itk and dask removed (after checking where it is used, seems it was only for monai imwrite which is not used); and a "Save location" tooltip has been added. If you have the time, could you quickly confirm that the install procedure for M1 in the README works as intended ? Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
- make itk and pyqt5 "optional dependency, as for m1 they cause issues!
- then run: `conda install -c anaconda pyqt` in the env
- Remove dask and itk requirements - Comment duplicate sections in setup.cfg
6fcf862
to
0707e42
Compare
conda env create -f cellseg3d_m1.yml
conda activate cellseg3d_m1
conda install -c anaconda pyqt
in the env