Add support for custom routing field in OpenSearch requests #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junu-kk
approved these changes
Jul 28, 2025
Claudenw
requested changes
Jul 28, 2025
Comment on lines
+194
to
+196
| final var fieldPath = routingFieldPath.get(); | ||
| final var pathSegments = fieldPath.split("\\."); | ||
|
|
There was a problem hiding this comment.
What happens if fieldPath is an empty string? I think the config definition needs a non-empty validation check.
|
|
||
| // Test with IndexRequest | ||
| final var configForIndex = new OpensearchSinkConnectorConfig( | ||
| Map.of(OpensearchSinkConnectorConfig.CONNECTION_URL_CONFIG, "http://localhost", |
There was a problem hiding this comment.
Can you convert this to a parameter driven test and show that the extraction works with various combinations of config settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some options related to OpenSearch routing (#300). Happy to contribute this + any review requests!