Skip to content

修复bug #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

修复bug #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a1147
修复bug
JasonQS Nov 2, 2018
87b49ef
Update VersionDialogActivity.java
JasonQS Nov 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion library/src/main/java/com/allenliu/versionchecklib/core/VersionDialogActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,13 @@ protected void downloadFile() {


protected void requestPermissionAndDownloadFile() {
// if dir is writable, skip checking permission
if (new File(versionParams.getDownloadAPKPath()).canWrite()) {
Log.i(TAG, "requestPermissionAndDownloadFile: " + new File(versionParams.getDownloadAPKPath()).canWrite());
downloadFile();
}
// Here, thisActivity is the current activity
if (ContextCompat.checkSelfPermission(this,
else if (ContextCompat.checkSelfPermission(this,
Manifest.permission.WRITE_EXTERNAL_STORAGE)
!= PackageManager.PERMISSION_GRANTED) {

Expand Down