Skip to content

Conversation

jernejg
Copy link
Contributor

@jernejg jernejg commented Jan 14, 2025

Pull Request

The issue or feature being addressed

The descriptions of ResiliencePipelineProvider & ResiliencePipelineRegistry are swapped.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@jernejg jernejg changed the title Fix Register vs. Provider Migration doc typo Fix Registry vs. Provider Migration doc typo Jan 14, 2025
@jernejg
Copy link
Contributor Author

jernejg commented Jan 14, 2025

@dotnet-policy-service agree

@jernejg
Copy link
Contributor Author

jernejg commented Jan 14, 2025

@jernejg please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@martincostello martincostello enabled auto-merge (squash) January 15, 2025 08:35
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (4ed4d47) to head (eae45a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2447   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         312      312           
  Lines        7464     7464           
  Branches     1121     1121           
=======================================
  Hits         6374     6374           
  Misses        905      905           
  Partials      185      185           
Flag Coverage Δ
linux 85.36% <ø> (ø)
macos 85.39% <ø> (ø)
windows 85.36% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 8e42d3c into App-vNext:main Jan 15, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants