Minor tweaks to Freebooter ship cost #21306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aurora.3/maps/_common/mapsystem/map.dm
Lines 309 to 318 in e1226fc
Ship cost doesn't play a role here when a map is picked among the candidates pool. There is no reason to not treat a variation ship as a full ship after it's chosen. This was leaving budget points as a decimal number, preventing the loop from ending early before eliminating each candidates.
This doesn't change the outcome but makes it more in line with the intended standard. I had no idea about this at the time when I made freebooter variation (oops)