Skip to content

Conversation

kano-dot
Copy link
Contributor

@kano-dot kano-dot commented Sep 4, 2025

while ((points > 0 || shippoints > 0) && length(available))
var/datum/map_template/ruin/away_site/site = pickweight(available)
if ((site.spawn_cost && site.spawn_cost > points) || (site.player_cost && site.player_cost > players) || (site.ship_cost && site.ship_cost > shippoints))
unavailable += site
available -= site
continue
var/list/costs = resolve_site_selection(site, selected, available, unavailable, by_type)
points -= costs[1]
players -= costs[2]
shippoints -= costs[3]

Ship cost doesn't play a role here when a map is picked among the candidates pool. There is no reason to not treat a variation ship as a full ship after it's chosen. This was leaving budget points as a decimal number, preventing the loop from ending early before eliminating each candidates.

This doesn't change the outcome but makes it more in line with the intended standard. I had no idea about this at the time when I made freebooter variation (oops)

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Sep 4, 2025
@kano-dot
Copy link
Contributor Author

kano-dot commented Sep 4, 2025

!review

@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Sep 15, 2025
Merged via the queue into Aurorastation:master with commit b4f8b99 Sep 15, 2025
24 checks passed
@kano-dot kano-dot deleted the freebooter-cost-tweak branch September 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants