Skip to content

feat(auto_balancer): only use pending append/fetch latency to identif… #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

feat(auto_balancer): only use pending append/fetch latency to identif… #2632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/kafka/autobalancer/common/types/RawMetricTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class RawMetricTypes {
public static final byte BROKER_MAX_PENDING_FETCH_LATENCY_MS = (byte) 5;
public static final byte BROKER_METRIC_VERSION = (byte) 6;
public static final Map<Byte, AbnormalMetric> ABNORMAL_METRICS = Map.of(
BROKER_APPEND_LATENCY_AVG_MS, new AbnormalLatency(100), // 100ms
// BROKER_APPEND_LATENCY_AVG_MS, new AbnormalLatency(100), // 100ms
BROKER_MAX_PENDING_APPEND_LATENCY_MS, new AbnormalLatency(10000), // 10s
BROKER_MAX_PENDING_FETCH_LATENCY_MS, new AbnormalLatency(10000) // 10s
);
Expand Down
28 changes: 14 additions & 14 deletions core/src/test/java/kafka/autobalancer/model/ClusterModelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,20 +489,20 @@ public void testSlowBroker() {
clusterModel.unregisterBroker(0);

// test high append latency
clusterModel.onBrokerRegister(registerBrokerRecord0);
for (int i = 0; i < 100; i++) {
Assertions.assertTrue(clusterModel.updateBrokerMetrics(0, createBrokerMetrics(0,
0, 0, 0, MetricVersion.V1).getMetricValueMap().entrySet(), System.currentTimeMillis()));
}
snapshot = clusterModel.snapshot();
snapshot.markSlowBrokers();
Assertions.assertFalse(snapshot.broker(0).isSlowBroker());
Assertions.assertTrue(clusterModel.updateBrokerMetrics(0, createBrokerMetrics(0,
2000, 0, 0, MetricVersion.V1).getMetricValueMap().entrySet(), System.currentTimeMillis()));
snapshot = clusterModel.snapshot();
snapshot.markSlowBrokers();
Assertions.assertTrue(snapshot.broker(0).isSlowBroker());
clusterModel.unregisterBroker(0);
// clusterModel.onBrokerRegister(registerBrokerRecord0);
// for (int i = 0; i < 100; i++) {
// Assertions.assertTrue(clusterModel.updateBrokerMetrics(0, createBrokerMetrics(0,
// 0, 0, 0, MetricVersion.V1).getMetricValueMap().entrySet(), System.currentTimeMillis()));
// }
// snapshot = clusterModel.snapshot();
// snapshot.markSlowBrokers();
// Assertions.assertFalse(snapshot.broker(0).isSlowBroker());
// Assertions.assertTrue(clusterModel.updateBrokerMetrics(0, createBrokerMetrics(0,
// 2000, 0, 0, MetricVersion.V1).getMetricValueMap().entrySet(), System.currentTimeMillis()));
// snapshot = clusterModel.snapshot();
// snapshot.markSlowBrokers();
// Assertions.assertTrue(snapshot.broker(0).isSlowBroker());
// clusterModel.unregisterBroker(0);

// test high pending append latency
clusterModel.onBrokerRegister(registerBrokerRecord0);
Expand Down
Loading