Skip to content

fix(logCleaner): optimize write buffer management and clear buffer before use #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix(logCleaner): optimize write buffer management and clear buffer before use #2704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/main/scala/kafka/log/LogCleaner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,9 @@ private[log] class Cleaner(val id: Int,
}
for (batch <- fetchDataInfo.records.batches().asScala) {
checkDone(topicPartition)

writeBuffer.clear();

val records = MemoryRecords.readableRecords(batch.asInstanceOf[DefaultRecordBatch].buffer())
throttler.maybeThrottle(records.sizeInBytes)
val result = records.filterTo(topicPartition, logCleanerFilter, writeBuffer, maxLogMessageSize, decompressionBufferSupplier)
Expand All @@ -1241,7 +1244,13 @@ private[log] class Cleaner(val id: Int,
dest.append(result.maxOffset, result.maxTimestamp, result.shallowOffsetOfMaxTimestamp(), retained)
throttler.maybeThrottle(outputBuffer.limit())
}

// Grow the write buffer if needed, avoid always allocate a new buffer.
if (result.outputBuffer.capacity() > this.writeBuffer.capacity()) {
this.writeBuffer = ByteBuffer.allocate(result.outputBuffer.capacity())
}
}
restoreBuffers()
}

private def buildOffsetMapForSegmentV2(topicPartition: TopicPartition,
Expand Down
Loading