Skip to content

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 12, 2025

Fix

This is part of our effort to move away from CocoaPods, which is now in maintenance mode, in favor of Swift Package Manager. See https://linear.app/a8c/issue/AINFRA-448.

Test

I made sure the app built locally.

Review

Only one developer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@mokagio mokagio added this to the Future milestone Jun 12, 2025
@mokagio mokagio self-assigned this Jun 12, 2025
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Jun 12, 2025
Comment on lines +6152 to +6153
kind = exactVersion;
version = 0.9.15;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used exact to match the version resolved in Podfile.lock and avoid introducing changes because of fetching a newer version (at the time of writing, the latest is 0.9.19).

We can always follow up with a dedicated PR to update.

@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build
Build Number1287
VersionPR #1713
Bundle IDcom.codality.NotationalFlow.Alpha
Commitbb8ba9c
Installation URL13b2qmci4onq8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio requested a review from a team June 12, 2025 07:20
@AliSoftware
Copy link
Contributor

The UI Tests CI job is failing because it seems it doesn't find the JSON used to handle test accounts used for those UI Tests

This seems unrelated to the changes in this PR and more likely related to the URL we used to store those not being valid anymore (hence the body of the request being just the text Not Found instead of the expected JSON, leading to JSON parsing error)

The value of UI_TESTS_ACCOUNTS_JSON_URL env var—as provided via .mobile-secrets—is a URL to https://kvdb.io/<someid>/… so I guess maybe our subscription to that service expired or something? (though I haven't found credentials for such service in Secret Store, so unable to verify)

@mokagio mokagio merged commit 2ce0bcc into trunk Jun 12, 2025
10 of 12 checks passed
@mokagio mokagio deleted the ainfra-448-migrate-simplenote-ios-pods-to-swiftpm-zipfoundation branch June 12, 2025 21:15
This was referenced Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants