Skip to content

Provision SwiftLint using SwiftPM instead of CocoaPods #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

Provision SwiftLint using SwiftPM instead of CocoaPods #1242

merged 2 commits into from
Jun 12, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 12, 2025 •
edited
Loading

@mokagio mokagio added this to the Future milestone Jun 12, 2025
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Jun 12, 2025
@mokagio mokagio self-assigned this Jun 12, 2025
@mokagio mokagio requested a review from a team June 12, 2025 03:32
@mokagio mokagio marked this pull request as ready for review June 12, 2025 03:32
AliSoftware
AliSoftware approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, but with the same note about running rake from Xcode's Script Build Phase.

Could be ok for now to unblock progress then be addressed in later PR though?

Simplenote.xcodeproj/project.pbxproj
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "[ $CI ] && exit 0\n./Pods/SwiftLint/swiftlint\n\n";
shellScript = "[ $CI ] && exit 0\nrake lint\n\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same concern as with companion iOS PR here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: Automattic/simplenote-ios#1712 (comment)

Moved this discussion internally to paaHJt-8yZ-p2

@mokagio mokagio merged commit 36b0904 into trunk Jun 12, 2025
12 checks passed
@mokagio mokagio deleted the ainfra-451-provision-swiftlint-via-swiftpm branch June 12, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees

@mokagio mokagio

Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
2 participants
@mokagio @AliSoftware