Skip to content

Conversation

Roopan-Microsoft
Copy link
Contributor

Purpose

This pull request updates the Teams extension to support single-tenant authentication for the bot and ensures proper Azure resource provisioning. The changes include switching the bot registration and configuration to single-tenant mode, passing the tenant ID throughout the deployment pipeline, and adding automation to enable a service principal for the bot application.

Authentication and Bot Registration

  • Changed bot registration from multi-tenant to single-tenant by updating MicrosoftAppType and adding MicrosoftAppTenantId in index.ts and ARM/Bicep templates. This enforces authentication to a specific tenant. [1] [2]
  • Added tenantId to the runtime configuration (config.ts) and ensured it is provided via environment variables and deployment templates. [1] [2] [3]

Infrastructure and Deployment

  • Updated Bicep templates to accept and propagate the tenant ID parameter for bot registration, and increased the maximum length for resource names to avoid deployment issues. [1] [2] [3]

Automation and Developer Experience

  • Added a script (enable-service-principal.js) and corresponding npm command to automatically create a service principal for the bot application using Azure CLI, improving deployment reliability. [1] [2] [3]

Build Configuration

  • Updated TypeScript configuration to use Node 16 module and resolution settings for compatibility with newer Node.js features.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Roopan-Microsoft and others added 30 commits November 25, 2024 16:02
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Ross Smith <[email protected]>
Co-authored-by: gpickett <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Prajwal D C <[email protected]>
…nd Update Conversation flow based on template selection (#1567)

Co-authored-by: Pavan Kumar <v-kupavan.microsoft.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pavan-Microsoft <[email protected]>
Prajwal-Microsoft and others added 20 commits June 12, 2025 10:36
…grated vectorization (#1839)

Co-authored-by: Vamshi-Microsoft <[email protected]>
Co-authored-by: Prajwal-Microsoft <[email protected]>
…test orchestration, and improved Makefile targets (#1855)

Co-authored-by: Harmanpreet Kaur <[email protected]>
…d maintenance (#1880)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Pavan-Microsoft <[email protected]>
Co-authored-by: Prasanjeet-Microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
Rohini-Microsoft and others added 2 commits September 22, 2025 10:07
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Pavan-Microsoft <[email protected]>
Co-authored-by: Roopan-Microsoft <[email protected]>
Co-authored-by: Ajit Padhi <[email protected]>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Ross Smith <[email protected]>
Co-authored-by: gpickett <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Francia Riesco <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
Co-authored-by: UtkarshMishra-Microsoft <[email protected]>
Co-authored-by: Priyanka-Microsoft <[email protected]>
Co-authored-by: Prasanjeet-Microsoft <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiran-Siluveru-Microsoft <[email protected]>
Co-authored-by: Prashant-Microsoft <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
Co-authored-by: Avijit-Microsoft <[email protected]>
Co-authored-by: RaviKiran-Microsoft <[email protected]>
Co-authored-by: Somesh Joshi <[email protected]>
Co-authored-by: Himanshi Agrawal <[email protected]>
Co-authored-by: pradeepjha-microsoft <[email protected]>
Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Bangarraju-Microsoft <[email protected]>
Co-authored-by: Harsh-Microsoft <[email protected]>
Co-authored-by: Kanchan-Microsoft <[email protected]>
Co-authored-by: Cristopher Coronado <[email protected]>
Co-authored-by: Cristopher Coronado Moreira <[email protected]>
Co-authored-by: Vamshi-Microsoft <[email protected]>
Co-authored-by: Thanusree-Microsoft <[email protected]>
Co-authored-by: Niraj Chaudhari (Persistent Systems Inc) <[email protected]>
Co-authored-by: Rohini-Microsoft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.