Reverted log4j shading due to regressions caused. #46546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kirankumarkolli and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the log4j shading changes that were introduced in version 4.38.1 due to regressions they caused. The change removes log4j from the shaded packages and adds a safety check to ensure Azure Monitor logging is only configured when explicitly enabled.
Key Changes:
- Reverted log4j-core and log4j-slf4j-impl shading configuration from the Maven POM
- Added an additional condition to check
azMonConfig.enabledbefore configuring Azure Monitor logging - Updated changelog to document the regression and reversion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos-spark_3_2-12/pom.xml | Removed log4j shading configuration that caused regressions |
| sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosClientCache.scala | Added enabled check before configuring Azure Monitor logging |
| sdk/cosmos/azure-cosmos-spark_3-5_2-12/CHANGELOG.md | Updated changelog to document the regression and its fix |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tvaron3
approved these changes
Sep 3, 2025
…to users/fabianm/log4jShadingRegressionFix
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tvaron3
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverting the change to shade log4j. Log4j documentation clealry calls out that either wihtin an application log4j should be shaded everywhere - or nowhere. Mixing shaded and unshaded log4j depdnencies can cause issues due to loading several dependencies via reflection etc. Since within the Spark connector we don't own the application - we can only follow what Spark is doing and not shade log4j and live with/workaorund any possible versioning conflicts.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines