Removing dependencies on Log4j (and as a necessary side effect stopping to export Log4J logs to Azuremonitor) #46608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
kirankumarkolli and
a team
as code owners
|
/azp run java - cosmos - spark |
There was a problem hiding this comment.
Pull Request Overview
This PR removes Log4j dependencies from the Azure Cosmos Spark connector to resolve conflicts in Fabric/Synapse and ADF environments. The change eliminates the export of Spark Log4j logs to Azure Monitor while maintaining metrics and traces functionality.
- Removes all Log4j-related Maven dependencies and imports
- Eliminates Azure Monitor log configuration parameters and associated code
- Updates test cases to remove log-related assertions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Removes Log4j Maven dependencies and OpenTelemetry log-related dependencies |
| AzureMonitorConfig.scala | Removes log-related parameters from the AzureMonitorConfig case class |
| CosmosConfig.scala | Removes log configuration entries and related parsing logic |
| CosmosClientCache.scala | Removes Log4j imports and log configuration methods |
| CosmosClientConfigurationSpec.scala | Removes Log4j import and log-related test assertions |
| configuration-reference.md | Removes documentation for log-related configuration parameters |
sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
requested review from
alzimmermsft,
samvaity,
g2vinay,
JonathanGiles,
rujche,
Netyyyy,
saragluna,
moarychan and
a team
as code owners
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exporting the Spark Log4j logs to AzureMonitor along with metrics and traces causes issues due tot Log4j conflicts in Fabirc/Snypase and ADF - to mitigate those we have stopped exporting Log4j logs to AzureMonitor for now - we might reintorduce this later when identifying a safe way to avoid the Log4j conflicts.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines