fix(playwrighttesting): Fixed bug of Migration To ESM #35873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ESM (ECMAScript Module) migration issues in the microsoft-playwright-testing package by addressing import/require conflicts and updating TypeScript configurations.
- Replaced
require()calls with ESM-compatible module loading usingcreateRequirefrom Node.js - Refactored package version retrieval to work in both ESM and CommonJS environments
- Updated TypeScript configuration files for proper ESM formatting
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.src.json | Reformatted array formatting for consistency |
| tsconfig.snippets.json | Reformatted array formatting for consistency |
| tsconfig.samples.json | Reformatted array formatting for consistency |
| tsconfig.browser.config.json | Reformatted array formatting for consistency |
| src/utils/utils.ts | Replaced require-based package version loading with new ESM-compatible approach |
| src/utils/getPackageVersion.ts | New ESM module for package version retrieval using createRequire |
| src/utils/getPackageVersion-cjs.cts | New CommonJS module for package version retrieval |
| src/core/playwrightServiceUtils.ts | Updated ESM path construction with improved variable naming |
| src/core/playwrightServiceUtils-cjs.cts | Simplified path joining logic |
| eslint.config.mjs | Removed deprecated ESLint rule exclusion |
puagarwa
reviewed
Sep 9, 2025
| __dirname, | ||
| "./global/playwright-service-global-teardown.js", | ||
| ); | ||
| export const globalSetupPath = path.join(path.join(__dirname, "./global/playwright-service-global-setup.js")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists