Use azure-json in claims classes #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
May 7, 2025
billwert
approved these changes
May 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates claims-related classes to replace Jackson JSON processing with azure-json while adding new test cases to ensure proper JSON serialization and deserialization.
- Implements the JsonSerializable interface for claims classes
- Removes Jackson JSON annotations and replaces them with azure-json APIs
- Adds unit tests to validate JSON conversions and error handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ClaimsTest.java | Added new tests to verify JSON serialization of claims with azure-json APIs |
| msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RequestedClaimAdditionalInfo.java | Migrated JSON serialization/deserialization to azure-json |
| msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/RequestedClaim.java | Updated JSON conversion methods using azure-json; adjusted factory method for claim parsing |
| msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/ClaimsRequest.java | Replaced Jackson processing with azure-json implementations in serialization and parsing logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces usage of com.fasterxml.jackson with com.azure.json, as per #909
This PR changes to claims-related classes which are similar to those done in #918: