Material: Add support for clustered lights to node materials #17180
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17180/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17180/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17180/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
I restarted the CI 3 times, it always fails on a timeout in the interaction tests: 
[EDIT] I ran tests locally to perform interaction tests without my PR (relative to the main branch of Babylon.js), and they also fail with a timeout. |
… nodemat-clusterlights
|
cc @ryantrem / @VicenteCartas |
|
WebGL2 visualization test reporter: |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
| return dot(value, vec3(0.333333333)); | ||
| } | ||
|
|
||
| #ifdef WEBGL2 |
There was a problem hiding this comment.
Yup this is causing an error during tests:
BJS - [16:03:45]: Error: VERTEX SHADER ERROR: 0:163: 'uint' : syntax error
There are two subtleties related to handling clustered lights in node materials. I have updated the documentation accordingly:
BabylonJS/Documentation#1400