Skip to content

Handle missing directories #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle missing directories #16

wants to merge 1 commit into from

Conversation

gquintana
Copy link
Contributor

Trying to fix #10.

I introduced a configurable "missing directory" strategy:

  • "fail" is default behaviour (HDFS)
  • "create" auto creates target directory if not exist (HDFS)
  • "log" doesn't fail nor create directories because it's not needed (S3, Ceph and other object storage)

Apologies for code quality, I am not fluent in Scala, tell me how to fix and improve.

@gquintana gquintana force-pushed the bugfix/dirnotexist branch 7 times, most recently from 81b8b16 to a58ae2e Compare February 7, 2022 15:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 38 Code Smells

No Coverage information No Coverage information
33.5% 33.5% Duplication

@gquintana
Copy link
Contributor Author

I did my best to reduce code duplication and comply with SonarCloud check.
Sadly I could achieve it.
Note that I did'nt introduce most of this duplicated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When target directory not exists, distcp fails due to listing
1 participant
@gquintana