Skip to content

Conversation

PROFeNoM
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Sep 22, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (b8bf258) to head (d957985).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
- Coverage   61.90%   61.74%   -0.17%     
==========================================
  Files         141      141              
  Lines       12481    12481              
  Branches     1630     1630              
==========================================
- Hits         7726     7706      -20     
- Misses       4033     4054      +21     
+ Partials      722      721       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bf258...d957985. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Sep 22, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-09-22 09:03:56

Comparing candidate commit d957985 in PR branch alex/fix/sc-rust-parity with baseline commit b8bf258 in branch master.

Found 4 performance improvements and 5 performance regressions! Performance is the same for 185 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-3.377µs; -2.423µs] or [-3.069%; -2.202%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-5.340µs; -4.000µs] or [-4.674%; -3.501%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+62.411ns; +121.989ns] or [+5.290%; +10.339%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+93.136ns; +135.864ns] or [+8.044%; +11.734%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+89.436ns; +145.964ns] or [+7.624%; +12.443%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+50.122ns; +126.078ns] or [+4.218%; +10.611%]

scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache

  • 🟥 execution_time [+3.440µs; +7.690µs] or [+2.006%; +4.485%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-65.763µs; -39.537µs] or [-5.106%; -3.070%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-33.838µs; -24.062µs] or [-7.677%; -5.459%]

@PROFeNoM PROFeNoM closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants