Add proper long path support on Windows #1365
Open
+112
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the magic of
overloadthis PR adds (mostly) transparent support for long paths on Windows.It works by overloading the test file operators with their long path compatible variants but it requires wrapping paths into objects for them to work. There are ways to do this more transparently but they are experimental and will break 3rd-party libs.
Utils/Path.pmhas been added to wrap some of the IO stuff, this is used in cases where long path support is required, which usually is during archive IO operations.On Windows it wraps paths into a custom object so that overload works and on Linux it becomes a noop stub.
Short paths are still used in some cases where a 3rd-party lib has no support, such as Mojo (currently used for archive downloads).
Win32::FileSystemHelper diff
(Redis is updated to match Alpine and included are the Karen changes as well)