Retire [@@must_erase_for_extraction]
#3883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weirdly enough, this breaks more than #3661. Quite a few assertions fail now (probably just require a higher rlimit though). https://github.com/FStarLang/FStar/actions/runs/16061262635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
[@@must_erase_for_extraction]attribute by the (existing)[@@erasable]attribute. To quote the type checker source:This PR contains the immediately applicable prefix of PR #3661.
The old attribute is marked as a deprecated alias for
[@@erasable], so there shouldn't be any failures. Unless you turn warnings into errors, as Inria projects do (remember to ping TWal after merging).