Skip to content

Conversation

David-GERARD
Copy link
Contributor

@David-GERARD David-GERARD commented Dec 3, 2024

Description

As planned for the release of version 1.24.4, we are removing support for python >3.9, and adding python 3.12 .

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@David-GERARD David-GERARD added documentation Improvements or additions to documentation enhancement New feature or request in progress python Pull requests that update Python code labels Dec 3, 2024
@David-GERARD David-GERARD self-assigned this Dec 3, 2024
@David-GERARD David-GERARD changed the title [Feat] Deprecate Python 3.8, add Python 3.12 and 3.13 [Feat] Deprecate Python 3.8, add Python 3.12 Dec 4, 2024
@David-GERARD
Copy link
Contributor Author

Pygame doesn't support python 3.13 yet, and due to the number of errors in CI, I am removing it and focussing this PR on python 3.12 only.

@David-GERARD David-GERARD added this to the 1.24.4 release milestone Dec 9, 2024
@mwydmuch mwydmuch mentioned this pull request Jan 7, 2025
7 tasks
@mwydmuch mwydmuch changed the title [Feat] Deprecate Python 3.8, add Python 3.12 [Feat] Deprecate Python 3.8, add Python 3.12 + update CI/CD Jan 7, 2025
@David-GERARD David-GERARD marked this pull request as ready for review February 8, 2025 21:57
@David-GERARD
Copy link
Contributor Author

As per gorakhargosh/pathtools#13, pathtools, a dependancy of AgileRL doesn't build python 3.12, and it doesn't seem like they will change it (see closed PR gorakhargosh/pathtools#14).

As such:

  • I removed python 3.12 from the AgileRL tutorial
  • I pinned the version in requirements.txt to be <3.12
  • I added a warning in the documentation in `PettingZoo/docs/tutorials/agilerl/index.md

@yjhan96 yjhan96 assigned David-GERARD and unassigned David-GERARD Feb 11, 2025
@David-GERARD David-GERARD merged commit 50195c2 into master Feb 15, 2025
42 checks passed
yjhan96 pushed a commit to anordin95/PettingZoo that referenced this pull request Feb 23, 2025
@David-GERARD David-GERARD deleted the upgrade_python_version branch April 11, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request in progress python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants