-
Notifications
You must be signed in to change notification settings - Fork 1
fix: ART-14528 Fix OpenTelemetry instrumentation version mismatch causing aggregation.createAggregator error in CI #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request upgrades several OpenTelemetry packages to version 0.200.0 and 1.21.0 to address version mismatches that were causing errors in CI. It also updates the way the service name is set in the NodeSDK configuration by using No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zalborzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be helpful to understand the reason for this large dependency update.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zalborzi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more specific version range (e.g.,
^1.21.0
) instead of exact versions for@opentelemetry
packages to allow for patch updates. - It might be helpful to add a comment explaining why these specific OpenTelemetry packages are being upgraded.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update OpenTelemetry dependencies to resolve version compatibility issues in instrumentation
New Features:
Bug Fixes:
Enhancements: