Skip to content

Conversation

zalborzi
Copy link
Contributor

@zalborzi zalborzi commented Apr 23, 2025

Summary by Sourcery

Update OpenTelemetry dependencies to resolve version compatibility issues in instrumentation

New Features:

  • Added @opentelemetry/sdk-node and @opentelemetry/resources dependencies

Bug Fixes:

  • Resolve OpenTelemetry instrumentation version mismatch that was causing aggregation errors in CI

Enhancements:

  • Upgrade OpenTelemetry packages to newer versions
  • Update resource creation method in instrumentation configuration

@zalborzi zalborzi self-assigned this Apr 23, 2025
Copy link
Contributor

sourcery-ai bot commented Apr 23, 2025

Reviewer's Guide by Sourcery

This pull request upgrades several OpenTelemetry packages to version 0.200.0 and 1.21.0 to address version mismatches that were causing errors in CI. It also updates the way the service name is set in the NodeSDK configuration by using resourceFromAttributes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgraded multiple OpenTelemetry packages to resolve version mismatches.
  • Upgraded @opentelemetry/api-logs from 0.57.0 to 0.200.0.
  • Upgraded @opentelemetry/exporter-logs-otlp-http from 0.57.0 to 0.200.0.
  • Upgraded @opentelemetry/exporter-metrics-otlp-proto from 0.57.0 to 0.200.0.
  • Upgraded @opentelemetry/instrumentation from 0.57.0 to 0.200.0.
  • Upgraded @opentelemetry/sdk-logs from 0.57.0 to 0.200.0.
  • Added @opentelemetry/sdk-node at version 0.200.0.
  • Upgraded @opentelemetry/resources to version 2.0.0.
package.json
package-lock.json
Replaced the Resource constructor with resourceFromAttributes to properly set service name.
  • Replaced new Resource with resourceFromAttributes.
  • Passes an object with the service name attribute to resourceFromAttributes.
src/instrumentation.node.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zalborzi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It would be helpful to understand the reason for this large dependency update.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zalborzi zalborzi changed the title fix: ART-14528 fix: ART-14528 Fix OpenTelemetry instrumentation version mismatch causing aggregation.createAggregator error in CI Apr 23, 2025
@zalborzi
Copy link
Contributor Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zalborzi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more specific version range (e.g., ^1.21.0) instead of exact versions for @opentelemetry packages to allow for patch updates.
  • It might be helpful to add a comment explaining why these specific OpenTelemetry packages are being upgraded.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@brunopacheco1 brunopacheco1 merged commit dccf40f into main Apr 23, 2025
4 checks passed
@brunopacheco1 brunopacheco1 deleted the ART-14528 branch April 23, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants