Fix #180: Improve efficiency of burn-in phase in sampling functions #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the efficiency of the burn-in phase in sampling functions by avoiding unnecessary storage and deletion of burn-in points. Instead of storing points during burn-in and then clearing them, we now use a
NoOpWalkPolicy
that simply discards these points.Changes
NoOpWalkPolicy
that discards points during burn-in phaseNoOpWalkPolicy
instead of store-and-clear approachBefore
After
Benefits
Testing
Added
burn_in_efficiency_test.cpp
that compares performance and verifies correctness of both implementations.Fixes #180