Skip to content

[UX] Copy fake EpicGamesLauncher.exe for games flagged with env variable (like Rockstar games) #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2025
Merged

[UX] Copy fake EpicGamesLauncher.exe for games flagged with env variable (like Rockstar games) #4385

merged 6 commits into from
May 22, 2025

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 4, 2025 •
edited
Loading

This PR depends on having the legendary binary from: Heroic-Games-Launcher/legendary#13

How to test:

  • Install GTAV or RDR2 or any rockstar game
  • configure the custom legendary binary from the link above
  • make sure the game is NOT configure with the fix.bat workaround
  • set an env variable for the game USE_FAKE_EPIC_EXE=true
  • launch the game

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

arielj
arielj commented Mar 4, 2025
View reviewed changes
@arielj arielj marked this pull request as ready for review April 1, 2025 01:22
@arielj arielj changed the title Copy fake EpicGamesLauncher.exe for games flagged with env variable [UX] Copy fake EpicGamesLauncher.exe for games flagged with env variable (like Rockstar games) Apr 1, 2025
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 7, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team April 7, 2025 21:05
Etaash-mathamsetty
Etaash-mathamsetty reviewed Apr 27, 2025
View reviewed changes
flavioislima
flavioislima approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@flavioislima flavioislima merged commit 1c59f96 into main May 22, 2025
7 of 9 checks passed
@flavioislima flavioislima deleted the epic-fake-exe branch May 22, 2025 17:50
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty left review comments

@flavioislima flavioislima flavioislima approved these changes

@imLinguin imLinguin imLinguin approved these changes

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arielj @flavioislima @CommandMC @Etaash-mathamsetty @imLinguin