Skip to content

[Feat] "Disable smooth scrolling" accessibility option #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

[Feat] "Disable smooth scrolling" accessibility option #4503

merged 2 commits into from
May 14, 2025

Conversation

CommandMC
Copy link
Collaborator

There's now a new toggle in the "Accessibility" screen to disable smooth scrolling
This was already possible by starting Heroic with --disable-smooth-scrolling, but in the long run that's rather clunky

Resolves #4502

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 2, 2025
@CommandMC CommandMC requested a review from a team May 2, 2025 10:45
@CommandMC CommandMC self-assigned this May 2, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team May 2, 2025 10:45
flavioislima
flavioislima approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CommandMC CommandMC merged commit a045c68 into main May 14, 2025
9 checks passed
@CommandMC CommandMC deleted the feat/unsmooth-scrolling branch May 14, 2025 13:34
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flavioislima flavioislima flavioislima approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees

@CommandMC CommandMC

Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a setting to disable smooth scrolling
2 participants
@CommandMC @flavioislima