Skip to content

Conversation

CommandMC
Copy link
Collaborator

Direct updates:

  • @vitejs/plugin-react-swc: 3.6.0 -> 3.9.0
  • electron-vite: 2.0.0 -> 3.1.0
  • vite-plugin-svgr: 4.2.0 -> 4.3.0

Important peer dependency updates:

  • vite: 5.2.8 -> 6.3.5
  • rollup: 4.17.2 -> 4.41.0

Note: I've removed our explicit vite dependency, since it's pulled in by electron-vite (& we only ever run Vite through electron-vite). This doesn't do much (we were already protected from peer dependency version mismatches by pnpm), but it makes the package slightly easier to update

I've tested starting the app normally (pnpm start) and AppImage & Windows builds on Linux. I don't think further testing is necessary, since the bundler should behave the same way on all platforms (and electron-builder wasn't updated)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

CommandMC added 2 commits May 18, 2025 12:18
`electron-vite` depends on it, and it's easier to update like this
@CommandMC CommandMC requested a review from a team May 18, 2025 10:32
@CommandMC CommandMC self-assigned this May 18, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team May 18, 2025 10:32
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 18, 2025
@flavioislima flavioislima merged commit 2c6545c into main May 19, 2025
12 of 15 checks passed
@flavioislima flavioislima deleted the update/vite branch May 19, 2025 10:32
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants