[Fix] Protocol handling on Windows #4534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a shortcut, Windows automatically adds a trailing
/
to the path. This caused Heroic to assume its parsing the old-style protocol URL, while it was actually getting a new-style one. Because of this, shortcuts created on Windows since Heroic 2.16 wouldn't actually workNote that this is a change on the handling side, meaning previously-non-working shortcuts will now just work again
Use the following Checklist if you have changed something on the Backend or Frontend: