Skip to content

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented May 18, 2025

When creating a shortcut, Windows automatically adds a trailing / to the path. This caused Heroic to assume its parsing the old-style protocol URL, while it was actually getting a new-style one. Because of this, shortcuts created on Windows since Heroic 2.16 wouldn't actually work

Note that this is a change on the handling side, meaning previously-non-working shortcuts will now just work again


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC requested a review from a team May 18, 2025 23:33
@CommandMC CommandMC self-assigned this May 18, 2025
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 18, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team May 18, 2025 23:33
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima merged commit 0d5fda9 into main May 19, 2025
9 checks passed
@flavioislima flavioislima deleted the fix/protocol-win branch May 19, 2025 10:30
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators May 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants