-
Notifications
You must be signed in to change notification settings - Fork 621
Copy avoid_realization
in run_conformance_test
#4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Copy avoid_realization
in run_conformance_test
#4536
Conversation
@contextmanager | ||
def with_register_backend(name, provider_cls): | ||
try: | ||
AVAILABLE_PROVIDERS[name] = provider_cls | ||
yield | ||
finally: | ||
del AVAILABLE_PROVIDERS[name] | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm naming this with the assumption that we'll migrate AVAILABLE_PROVIDERS
to def register_backend(name, class_or_string)
at some point
Nice! I don't have an informed opinion on the code changes, but I'll kick off a 50-repeat run of the reproducer on both windows and ubuntu. It usually failed at about 5 repeats, so if those pass I'll consider it solved.
Yes, most definitely! If it starts happening again we want to know. |
The ubuntu runner got a probably unrelated error after ~20 repeats, https://github.com/HypothesisWorks/hypothesis/actions/runs/17525804945/job/49776013140
I'll switch to windows runner and remove Aside: Consider migrating the currently windows-specific CI job configuration to tox and switch f.x. one of the older python job to run the same config? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is unrelated - crosshair hitting timeouts on a particularly slow CI run, perhaps.
I don't follow, what's the benefit of this? Is there some crosshair test or config which we're only running on windows, despite the |
The benefit for this issue (in hindsight) would have been to quickly identify the trigger as being the combination of tests rather than the platform. That may never happen again of course, but the windows runner differs also in dependency versions. Duplicating the setup to another platform would make any error that happens only on windows more likely to be windows-specific. But: from a quick glance I don't see that [edit: Sample toxified build matrix for windows+osx at the repurposed #4510) |
Right, this seems to be the biggest problem. Probably we should add a new linux CI entry to test |
Yes. Technically, something like |
(pending confirmation)closes #4442. Thanks to @pschanely and especially @jobh for getting to the bottom of this!