Skip to content

Conversation

lvhan028
Copy link
Collaborator

@lvhan028 lvhan028 commented Aug 7, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Align response behavior across both engines

from lmdeploy import pipeline, TurbomindEngineConfig, PytorchEngineConfig, GenerationConfig
gen_config = GenerationConfig(max_new_tokens=500)
backend_config = TurbomindEngineConfig(tp=1)
# backend_config = PytorchEngineConfig(tp=1)
pipe = pipeline('internlm/internlm3-8b-instruct',
                backend_config=backend_config,
                log_level='INFO',
                max_log_len=10
                )
response = []
for item in pipe.stream_infer('Hi, pls intro yourself'*10000):
    response.append(item)
print(response)

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 changed the title Report error when input len is greater than session_len Align response behavior across both engines Aug 7, 2025
@lvhan028 lvhan028 added the Bug:P1 label Aug 7, 2025
Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit ac47a51 into InternLM:main Aug 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants