Mark prompt builders with PromptDSL #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is possible to invoke the role-defining functions while already being inside them, for instance:
```
user {
system {
}
}
```
which, despite being valid code, is confusing.
We mark the TextContentBuilder with the PromptDSL annotation so that such calls, if intended, will need to explicitly specify the receiver.
sproshev
approved these changes
Jun 2, 2025
Ololoshechkin
pushed a commit
that referenced
this pull request
Jun 5, 2025
Currently, it is possible to invoke the role-defining functions while already being inside them, for instance:
```
user {
system {
}
}
```
which, despite being valid code, is confusing.
We mark the TextContentBuilder with the PromptDSL annotation so that such calls, if intended, will need to explicitly specify the receiver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to invoke the role-defining functions while already being inside them, for instance:
which, despite being valid code, is confusing.
We mark the TextContentBuilder with the PromptDSL annotation so that such calls, if intended, will need to explicitly specify the receiver.
Thank you for opening a pull request! Please add a brief description of the proposed change here.
Also, please tick the appropriate points in the checklist below.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature