Add parallel nodes invocation #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM136 new problems were found
@@ Code coverage @@
+ 52% total lines covered
5890 lines analyzed, 3109 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
tiginamaria
commented
Jun 10, 2025
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
tiginamaria
commented
Jun 10, 2025
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
tiginamaria
commented
Jun 10, 2025
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/context/AIAgentContext.kt
Outdated
Show resolved
Hide resolved
Rizzen
previously requested changes
Jun 10, 2025
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/context/AIAgentContext.kt
Outdated
Show resolved
Hide resolved
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
agents/agents-tools/src/commonMain/kotlin/ai/koog/agents/core/tools/ToolDescriptors.kt
Outdated
Show resolved
Hide resolved
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
|
@tiginamaria could you also rebase on latest develop? You have QD inspections because of little bit outdated branch |
Rizzen
reviewed
Jun 10, 2025
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/context/AIAgentContext.kt
Outdated
Show resolved
Hide resolved
tiginamaria
force-pushed
the
tigina/parallel-nodes
branch
from
b903bd5 to
62c9e78
Compare
agents/agents-core/src/commonTest/kotlin/ai/koog/agents/core/dsl/extension/ParallelNodesTest.kt
Outdated
Show resolved
Hide resolved
tiginamaria
force-pushed
the
tigina/parallel-nodes
branch
2 times, most recently
from
1e62ca8 to
3f71b34
Compare
ptitjes
reviewed
Jun 12, 2025
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
tiginamaria
commented
Jun 12, 2025
| ) | ||
|
|
||
| override suspend fun fork(): AIAgentContextBase { | ||
| TODO("Not yet implemented") |
There was a problem hiding this comment.
Should I implement fork/replace for the DummyAIAgentContext? And why we actually need it (I don't see any functionality that blocks from using just AIAgentContext, except all nullable values, or I'm missing something)?
ptitjes
reviewed
Jun 13, 2025
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
Ololoshechkin
requested changes
Jun 17, 2025
.../agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/builder/AIAgentSubgraphBuilder.kt
Outdated
Show resolved
Hide resolved
examples/src/main/kotlin/ai/koog/agents/example/parallelexecution/BestJokeAgent.kt
Outdated
Show resolved
Hide resolved
tiginamaria
force-pushed
the
tigina/parallel-nodes
branch
from
9b9e1d1 to
8c63f49
Compare
tiginamaria
force-pushed
the
tigina/parallel-nodes
branch
3 times, most recently
from
891baba to
b78cc97
Compare
Ololoshechkin
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
@tiginamaria I pushed a small change , please take a look :)
|
@tiginamaria please add more tests for the |
Rizzen
approved these changes
Jun 24, 2025
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/context/AIAgentContext.kt
Show resolved
Hide resolved
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/agent/entity/AIAgentState.kt
Outdated
Show resolved
Hide resolved
Add parallel node result type
tiginamaria
force-pushed
the
tigina/parallel-nodes
branch
from
fdd171a to
a1a5630
Compare
| * @param context The context to replace the current context with.]] | ||
| */ | ||
| override suspend fun replace(context: AIAgentContextBase) { |
There was a problem hiding this comment.
There's a potential problem with this method that might confuse someone (it confused me initially, at least). From the method signature and according to KDocs it looks like the whole context will be replaced, but in fact it's not the case and only three properties are actually replaced.
| private val mutableAIAgentContext = MutableAIAgentContext(llm, stateManager, storage) | ||
|
|
||
| override val llm: AIAgentLLMContext | ||
| get() = mutableAIAgentContext.llm |
There was a problem hiding this comment.
Also, for all these properties there's no RW lock. Meaning, when the replace operation is in progress, it's still possible to read from these fields, potentially getting inconsistent data (although the chances are probably very low)
| * Creates a copy of the current [MutableAIAgentContext]. | ||
| * @return A new instance of [MutableAIAgentContext] with copies of all mutable properties. | ||
| */ | ||
| suspend fun copy(): MutableAIAgentContext { |
There was a problem hiding this comment.
This method is not used
| AIAgentLLMContext( | ||
| tools.toList(), | ||
| toolRegistry, | ||
| prompt.copy(), |
There was a problem hiding this comment.
There's no need to unnecessary copy prompt and tools, these are already fully immutable
| llm.writeSession { | ||
| model = OpenAIModels.Chat.GPT4o | ||
| updatePrompt { | ||
| prompt("best-joke-selector") { |
There was a problem hiding this comment.
This part wouldn't work. updatePrompt accepts PromptBuilder and in its lambda returns Unit. It is meant to add more messages to existing prompt. In this case a new prompt is created and returned, but since the lambda is Unit, this operation essentially has no effect and the prompt remains the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parallel nodes execution implementation
#255