Removed suspend modifier from LLMClient.executeStreaming #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM5 new problems were found
☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
|
The change made by Qodana are unrelated to my changes, but seems like a correct fix. Should we make these changes separately, and rebase this PR? |
|
@nomisRev @EugeneTheDev @Ololoshechkin WDYT? |
EugeneTheDev
approved these changes
Jun 8, 2025
|
This looks good to me. Making the function both |
Rizzen
approved these changes
Jun 10, 2025
Ololoshechkin
approved these changes
Jun 10, 2025
|
@nomisRev please revert the Qodana change, and rebase to develop. As soon as your branch has qodana.yaml from develop, this change wouldn't happen :) |
…LLM clients and test classes.
nomisRev
force-pushed
the
remove-suspend-from-llmclient-streaming
branch
from
32809db to
59e3b3e
Compare
|
@Ololoshechkin Rebased, and all unrelated changes are now gone 👍 |
BLannoo
pushed a commit
to BLannoo/koog
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request! Please add a brief description of the proposed change here.
Flowandsuspendis typically redundant, but in this case no actualsuspendwas being used outside ofFlow, sosuspendcould simply be removed. I moved all eager executing code into theFlowcollector to be executed lazily, this aligns all implementations. There was also an instance of an unscopedlaunch, which is now properly scoped to theFlowexecution.Also, please tick the appropriate points in the checklist below.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature