[prompt] Improve attachments (former media content) support in prompt messages #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneTheDev
commented
Jun 11, 2025
| * @property id The unique identifier for the prompt. | ||
| * @property params The language model pa rameters associated with the prompt. Defaults to [LLMParams]. | ||
| */ | ||
| // FIXME move it from dsl package up to the module root package? |
There was a problem hiding this comment.
This is not related directly to this PR, but I've noticed it while preparing it and want to raise a question. Currently, Prompt class is located in the dsl package, which seems kinda strange, since it's not about DSL, but rather a core structure of this whole module, a prompt model. So I think it's better to move it to the root module package or at least together with other models to model
Qodana for JVM105 new problems were found
@@ Code coverage @@
+ 50% total lines covered
5804 lines analyzed, 2943 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
ptitjes
reviewed
Jun 11, 2025
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/message/Message.kt
Outdated
Show resolved
Hide resolved
ptitjes
reviewed
Jun 11, 2025
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/message/Attachment.kt
Outdated
Show resolved
Hide resolved
12 tasks
Ololoshechkin
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
@EugeneTheDev please change the method names to shorter polymorphic ones. Other things LGTM
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Outdated
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Outdated
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Outdated
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/dsl/AttachmentBuilder.kt
Outdated
Show resolved
Hide resolved
|
@EugeneTheDev could you also please check So either Ollama doesn't support anything but base64 -- then we have to also write this in KDocs. |
…ges. Make API more unified and stable
EugeneTheDev
force-pushed
the
eugenethedev/improve-media-content
branch
from
e4b003a to
1a3a957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on the changes made in #195 and improves existing attachments API, making it more clean, straightforward and versatile. Support providing binary data directly for all attachment types to support more cases, e.g. mobile devices or server that need to retrieve attachment content their own custom way. Also refactor the code, making it more structured and extensible.
Fixes #269, fixes #253