#288: Support providing custom LLM for fact retrieval in the history #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM377 new problems were found
@@ Code coverage @@
+ 64% total lines covered
7573 lines analyzed, 4917 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
tiginamaria
requested changes
Jun 23, 2025
...nts-features-memory/src/commonMain/kotlin/ai/koog/agents/memory/feature/nodes/MemoryNodes.kt
Outdated
Show resolved
Hide resolved
sdubov
approved these changes
Jun 23, 2025
...nts-features-memory/src/commonMain/kotlin/ai/koog/agents/memory/feature/nodes/MemoryNodes.kt
Show resolved
Hide resolved
...nts-features-memory/src/commonMain/kotlin/ai/koog/agents/memory/feature/nodes/MemoryNodes.kt
Show resolved
Hide resolved
agents/agents-core/src/commonMain/kotlin/ai/koog/agents/core/dsl/extension/AIAgentLLMActions.kt
Show resolved
Hide resolved
|
The PR is not linked to the issue that it fixes (only a commit is mentioned there), so here is the link: #288 |
Ololoshechkin
force-pushed
the
vbr/memory-model-selection
branch
from
84ebea6 to
a045616
Compare
|
Pls, update the description :) |
kpavlov
reviewed
Jul 12, 2025
| */ | ||
| public suspend fun saveFactsFromHistory( | ||
| concept: Concept, | ||
| subject: MemorySubject, | ||
| scope: MemoryScope, | ||
| retrievalModel: LLModel? = null |
There was a problem hiding this comment.
Can we make retrieval model required?
Suggested change
| retrievalModel: LLModel? = null | |
| retrievalModel: LLModel = model |
There was a problem hiding this comment.
No, it won't work, unfortunately, because model is only available inside llm.writeSession as it's a subject to change throughout the graph execution.
Ololoshechkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288
Allows to select an optional custom model for fact retrieval from the history in memory nodes and history compression nodes
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature